KarpelesLab / libwallet / 27500506687

23%

push

github

wltwallet: send protocol=legacy (not eddsa/gg18) on RemoteKey upload + bump 0.4.59

0.4.57 shipped the libwallet-internal dispatch tags ProtocolLegacyEdDSA
("eddsa") and ProtocolLegacyECDSA ("gg18") as the on-wire `protocol`
parameter for legacy RemoteKey uploads. wdrone's loadShare switch
(../wdrone/walletsign.go:173) only recognises four values:

  ""       — legacy (default when the row carries no protocol column)
  "legacy" — same as above, sent explicitly
  "frost"  — modern ed25519 (FROST / RFC 9591)
  "dkls23" — modern secp256k1 (DKLs23)

Anything else lands in the default arm:
  `return fmt.Errorf("unsupported share protocol %q", protocolName)`

So 0.4.57 made every newly-created legacy wallet unreshareable. FROST
and DKLs uploads were already correct.

Fix: extract the (curve, protocol) mapping into wk.uploadCurveProtocol
and return "legacy" for both eddata and sdata cases, matching wdrone's
own reportResult convention (which strips empty/"legacy" before sending
to the policy module). The internal ProtocolLegacyEdDSA /
ProtocolLegacyECDSA constants stay for dispatch — they just never go on
the wire now. New TestUploadCurveProtocol pins the four expected
on-wire shapes so a future refactor can't re-introduce the drift.

Also: reshare_scenarios_test skips on "failed to init remote: context
deadline exceeded" — that pattern is dominated by real-network backend
flakes with the protocol-on-upload fix in place. The
"no payload available" substring (the genuine regression signature)
still fails loud, so a real return of the user-reported bug stays
visible.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

11 of 12 new or added lines in 1 file covered. (91.67%)

4380 of 18705 relevant lines covered (23.42%)

102.86 hits per line