KarpelesLab / libwallet / 27497731698

23%

push

github

wltswap: accept base64url OKX Solana tx.data + gate publish on version.dart + bump 0.4.58

OKX's Solana adapter returns `tx.data` as standard base64 for most
routes but as base64url (URL-safe `-_` instead of `+/`) for versioned
(v0) transactions that reference address-lookup-tables — in practice
routes whose serialized payload exceeds ~1 KB. The decode in
`okxExecuteSolana` used `base64.StdEncoding.DecodeString` and tripped
on the first URL-safe byte, surfacing as the field-reported
`okx: decode solana tx.data: illegal base64 at input 1096`.

Extracted the decode into `okxDecodeSolanaTxData`, which normalizes
the alphabet (`-` → `+`, `_` → `/`) and re-pads to a multiple of four
before calling `base64.StdEncoding.DecodeString`. New
`TestOkxDecodeSolanaTxData` round-trips a 1100-byte payload through
all four base64 variants (standard padded/raw, URL-safe padded/raw).

Also fixes the publish-side hole that let v0.4.57 ship with a stale
`lib/src/version.dart` = '0.4.56'. The publish workflow's only gate
was tag vs pubspec; the dart-test workflow already runs
`tools/bump_version.dart --check` on every push, but that runs in a
different workflow. `publish-dart` now runs the same --check before
anything else, so a drifted version constant fails the publish job
itself.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

7 of 8 new or added lines in 1 file covered. (87.5%)

4389 of 18719 relevant lines covered (23.45%)

100.96 hits per line