KarpelesLab / libwallet / 27496480182

23%

Build Type

push

github

Committed by MagicalTux

Commit Message

fix CI: nil-guard Transaction.Validate + restore -short + tolerate RPC flakes

Three independent CI red causes after 0.4.56:

1. `Transaction.Validate` crashed with a nil-pointer panic for `transfer`
   and `solana_transfer`/`solana_spl_transfer` when `tx.Amount` was nil.
   The `erc20_transfer` and `bitcoin_transfer` branches already guarded
   with `tx.Amount == nil`; the two missing branches now do the same. The
   dart integration test "Transaction validate (missing fields returns
   error)" was hitting this path on every run — the panic was caught by
   apirouter and converted to a 500, which the test happened to swallow,
   but the panic itself was real.

2. `TestNftMetadata` was failing in the Tests workflow because commit
   dad66cd dropped the `-short` flag from the `go test` line. The test
   has `if testing.Short() { t.Skip(...) }` precisely because it depends
   on an external Ethereum contract still implementing tokenURI/uri/
   contractURI — without `-short` it runs against live RPC and breaks
   when the contract is upgraded or proxied. Restoring `-short` skips
   only this one test (it's the only one that consults `testing.Short()`).

3. The dart `Asset list` integration tests assumed `eth_getBalance`
   always succeeds. Infura periodically returns `-32603 Internal error`
   and we don't control that. Wrapped both tests in the same
   `try/catch on LibwalletException` pattern the testRpc and simulation
   tests already use — the contract decode still asserts correctness,
   transient upstream-RPC failures don't fail the build.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

0 of 2 new or added lines in 1 file covered. (0.0%)

79 existing lines in 2 files now uncovered.

4382 of 18712 relevant lines covered (23.42%)

101.12 hits per line