KarpelesLab / libwallet / 27490955804
23%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 128
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 22.349%. Remained the same
27490955804

push

github

MagicalTux 
wltwallet: cover reshare with [StoreKey + RemoteKey] vs [Password + RemoteKey] old committee

Field-reported regression: a Solana/FROST wallet whose user forgot
the Password should be able to reshare authorised by
[StoreKey + RemoteKey], rotating Password to a fresh value (per
dart/doc/device_share.md:3-5, "any two of them can sign or
reshare"). In production this fails with
"failed to start remote peer …: failed to init remote:
context deadline exceeded" 15 s in, while
[Password + RemoteKey] on the same wallet/device works.

Every existing reshare test in the package uses Type: "Plain"
shares — no RemoteKey, no wdrone, no Spot round trip. The TSS
math is well-covered by TestReshareDklsEndToEnd /
TestReshareFrostEndToEnd; the wire path to wdrone for non-Plain
committees had zero CI coverage. This file adds it.

Two tests sharing one helper:

- TestReshare_FROST_StoreKeyPlusRemote_AsOldCommittee — the
  failing scenario from the field report.
- TestReshare_FROST_PasswordPlusRemote_AsOldCommittee — the
  working control (the path tibaneapp's recoverDeviceShareVia2fa
  already uses). Both passing while the field path fails would
  localise the bug to wdrone-side per-committee state; both
  failing would mean libwallet itself regressed.

The helper goes through the same real backend
(remoteNew → remoteVerify → wallet keygen → remoteReshare →
remoteVerify → Wallet.Reshare) that TestRemoteWallet uses. Pre-
and post-reshare sign sanity checks confirm the wallet remains
usable end-to-end; pubkey preservation is asserted, plus a final
ed25519.Verify against the persisted pubkey so a regression that
silently changed the group key fails loud.

Both tests carry the documented phplatform-DB-blip skip so CI
stays green during backend wobbles. Un-skip locally to reproduce
the field report.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4176 of 18685 relevant lines covered (22.35%)

100.14 hits per line

Jobs
ID Job ID Ran Files Coverage
1 27490955804.1 128
22.35
 GitHub Action Run
Source Files on build 27490955804