MushroomObserver / mushroom-observer / 27491729513

98%

main: 99%

Build Type

Pull #4521

github

Committed by nimmolo

Commit Message

admin/blocked_ips: address third Copilot review pass

- Manager docstring: rendered by the Phlex `Edit` view (not
  `edit.html.erb`); filter form is type-agnostic, not blocked-only.
- Manager test helper: default `page`/`total_pages`/`total_count`
  to production-like values (1 / 1 / ips.size) so the default
  render mirrors the controller. `test_renders_without_pagination`
  opts into the nil/defensive path explicitly.
- Controller preload: limit `users_by_id` / `api_keys_by_str`
  preloads to the right column's actually-displayed IPs (top 50
  by load from `IpSummary` + the reported IP when set), instead
  of every entry in `@stats`. Prevents oversized `WHERE id IN
  (...)` / `WHERE key IN (...)` queries on busy stats hashes.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #4521: admin: convert remaining ERBs in app/views/controllers/admin to Phlex

Coverage Stats

216 of 311 new or added lines in 21 files covered. (69.45%)

2 existing lines in 1 file now uncovered.

46915 of 48114 relevant lines covered (97.51%)

694.84 hits per line