MushroomObserver / mushroom-observer / 27490847789

98%

main: 99%

Build Type

Pull #4521

github

Committed by nimmolo

Commit Message

admin: fix _Any prop guard + address Copilot review #2

CI was red on `NoAnyPhlexPropsTest` because
`Admin::Emails::MergeRequests::New` declared bare `_Any` props for
the two object instances. The rule lives in
`.claude/rules/phlex_conversions.md` ("ALWAYS use concrete prop
types — never `_Any` when the type is known"), and the controller
only ever passes a Herbarium / Location / Name instance per
`validate_merge_model!`. Switched to
`_Union(::Herbarium, ::Location, ::Name)`.

Second Copilot pass — all 4 valid:

1. `BlockedIpsController#edit` set `@ip` from `params[:report]`
   before stats were loaded, with no check that the IP appears in
   `@stats`. The per-IP stats subview would `NoMethodError` on
   `@stats[@ip][:user]` for a missing key. Extracted
   `#report_ip_if_present` that runs after stats load and short-
   circuits when the IP isn't in the hash.
2. `BlockedIpsController#load_paginated_ip_list` computed
   `page` from a `.to_i` of the raw param with no clamp. `page=0`
   makes `offset` negative (Ruby array slicing wraps to the end);
   `page=999999` slices past the array. Extracted `#clamp_page`
   that bounds the value to `[1, total_pages]`.
3-4. `Admin::DonationsController#edit` / `#update` were still
   building `@reviewed` — a hash of `donation.id => reviewed`. The
   Phlex `ReviewForm` reads `donation.reviewed` directly via
   `checked: donation.reviewed`, so `@reviewed` is dead state that
   only adds work on each request. Removed from both actions.

Pull Request Pull Request #4521: admin: convert remaining ERBs in app/views/controllers/admin to Phlex

Coverage Stats

211 of 306 new or added lines in 21 files covered. (68.95%)

2 existing lines in 1 file now uncovered.

46910 of 48109 relevant lines covered (97.51%)

695.49 hits per line