Freegle / Iznik / 21151

71%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(mail): harden render-failure retry — dead-letter alert + faithful digest rebuild (#593)

* feat(mail): durable retry for render failures via RetryableMailable + SpoolMail

Emails are rendered inline before anything durable is written to the spool,
so a render/build failure (e.g. a template referencing an undefined key during
a deploy window) threw before the message existed, was caught by the caller,
and the cursor advanced — silently dropping the recipient. ~1,100 immediate
digests were lost this way over one ~8-minute deploy window.

Add a generic, opt-in mechanism:
- RetryableMailable interface: mailDescriptor() (IDs only) +
  rebuildFromDescriptor() (re-fetch from DB; null cancels).
- EmailSpoolerService::spool() gains an $autoRetry flag: on a non-permanent
  build/render failure for a RetryableMailable it dispatches a SpoolMail job
  instead of rethrowing (the drop), then returns ''.
- SpoolMail (ShouldQueue): rebuilds a fresh mailable from current DB state and
  re-spools with autoRetry:false (no recursion); retryUntil(+24h) + capped
  backoff, then failed_jobs. A fix deployed within 24h drains automatically.
- Onboard UnifiedDigest (the incident) and ChatNotification.
- monitor:email-health alerts 24/7 on parked SpoolMail jobs; mail:retry-failed
  re-drives them after a fix lands.

Native Laravel queue retry is reused (queue:work --tries already runs in
supervisor). Only failures touch the queue; the high-volume inline render/spool
path is unchanged, so digest throughput is unaffected.

All 23 new tests pass (EmailSpoolerRetry, SpoolMail, UnifiedDigestRetry,
ChatNotificationRetry, EmailHealthDeadLetter, RetryFailedMailCommand).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(digest): round-trip daily "came and went" section through render-failure retry

UnifiedDigest's constructor gained a 5th arg, $completedPosts (the daily
Taken/Received "came and went" section, populated by the live send path),
after this branch's retry d... (continued)

Coverage Stats

10803 of 14375 branches covered (75.15%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 3 files covered. (100.0%)

634 existing lines in 14 files now uncovered.

117683 of 166166 relevant lines covered (70.82%)

35.78 hits per line