dangernoodle-io / breadboard / 27473603576

100%

push

github

fix(bb_mqtt): run reconfigure/stop on a dedicated task — was overflowing the httpd thread stack on live enable (#420)

* fix(bb_mqtt): run reconfigure/stop on a dedicated task — was overflowing the httpd thread stack on live enable

- spawn a one-shot freertos task ("mqtt_reconf", 8192-byte stack) from
  bb_mqtt_reconfigure() to perform the heavy esp-mqtt stop→destroy→init
  →start + mbedtls chain off the caller's thread
- httpd worker stack is only 6144 bytes; the synchronous path (ba77f32)
  overflows it on live patch /api/telemetry {"mqtt":{"enabled":true}}
- boot path (bb_mqtt_autoregister_init) runs on the 8192-byte main task
  and continues to call bb_mqtt_init directly — no change needed there
- reentrancy: s_reconfig_lock is taken by the caller before xTaskCreate
  and released by the worker just before vTaskDelete(NULL); rapid
  concurrent calls coalesce (find mutex taken, return BB_OK immediately)
- bb_mqtt_stop: synchronous destroy is retained (the stop path is called
  from sink teardown which runs from the bb_pub worker at 8192 bytes, not
  from httpd); no behaviour change needed for b1-275 callers
- update bb_mqtt.h docstrings to document async semantics on esp-idf
- extend host tests: deferred lifecycle trigger, reentrancy coalescing,
  enable→async-connect, disable→stop, re-enable cycles (5 new tests)
- all 2050 host tests pass

needs on-hardware confirmation: release http slot, enable mqtt live,
expect 204 + no stack-overflow panic

* fix(bb_mqtt): reconfigure lock must be a binary semaphore — cross-task give from the worker was asserting (mutex ownership)

1665 of 1665 branches covered (100.0%)

Branch coverage included in aggregate %.

2775 of 2775 relevant lines covered (100.0%)

1097.11 hits per line