dangernoodle-io / breadboard / 27472076882

100%

push

github

fix(bb_mqtt): harden bb_mqtt_reconfigure live teardown/re-init (was crashing on live enable — InstrFetchProhibited) (#419)

- add h->destroyed flag set under h->lock before esp_mqtt_client_destroy;
  mqtt_event_handler checks the flag on entry and returns immediately —
  prevents queued-but-not-yet-dispatched events from firing into freed memory
  after bb_mqtt_destroy returns (root cause of InstrFetchProhibited on live
  mqtt enable via PATCH /api/telemetry)
- guard esp_mqtt_client_stop behind h->started: calling stop on an unstarted
  client is benign in some esp-mqtt versions but triggers internal assertions
  in others; skip it when the client was never started (disabled→enabled path)
- tighten s_pending_start guard in bb_mqtt_reconfigure: add explicit NULL
  check before comparing to s_auto_client
- clarify deferred-start race window: after bb_wifi_register_on_got_ip fires
  on_got_ip_cb synchronously (s_has_ip already true), h->started is set by
  mqtt_start_once; log the deferred message only when start was truly deferred
- add bb_mqtt_stop(bb_mqtt_t *handle_p): idempotent stop+destroy+NULL for
  B1-275 telemetry sink teardown; exposed in public header and host stub
- 9 new host tests: bb_mqtt_stop lifecycle (null safety, clears handle,
  idempotent, publish-after-stop guard), enabled→disabled→enabled lifecycle,
  reconfigure from no-client (disabled-at-boot path), default-null-after-stop

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

1665 of 1665 branches covered (100.0%)

Branch coverage included in aggregate %.

2775 of 2775 relevant lines covered (100.0%)

1095.65 hits per line