open-quantum-safe / liboqs / 27421412329

82%

Build Type

push

github

Committed by web-flow

Commit Message

Fix uninitialized encaps_derand pointer dereference for NTRU KEMs (#2460)

* Fix uninitialized encaps_derand pointer dereference for NTRU KEMs

The six NTRU KEM constructors (hps2048509, hps2048677, hps4096821,
hps40961229, hrss701, hrss1373) did not initialize the encaps_derand
function pointer in OQS_KEM, and OQS_KEM_encaps_derand did not guard
against a NULL function pointer. Calling OQS_KEM_encaps_derand on an
NTRU KEM dereferenced uninitialized heap memory, causing a crash.

Three layers of fix:

1. Add explicit OQS_KEM_ntru_<scheme>_encaps_derand stubs returning
   OQS_ERROR (matching the existing keypair_derand stubs), and wire
   them into the NTRU constructors.

2. NULL-check the function pointer in all five OQS_KEM_* API wrappers
   in src/kem/kem.c as defense in depth against future omissions.

3. Switch all KEM constructors from OQS_MEM_malloc to OQS_MEM_calloc
   so any unset field is guaranteed NULL, making the API NULL check
   reliable. The jinja template in scripts/copy_from_upstream is
   updated to match.

Reported by Arthur Chan of Ada Logics on behalf of Anthropic.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Signed-off-by: Douglas Stebila <dstebila@uwaterloo.ca>

* Apply uninitialized-pointer hardening to SIG and SIG_STFL

Following the same approach as the NTRU encaps_derand fix for KEM,
apply defense-in-depth hardening so that any future SIG/SIG_STFL
constructor that forgets to initialize a function pointer returns
OQS_ERROR instead of dereferencing uninitialized heap memory.

For SIG:
1. NULL-check the function pointer in all five OQS_SIG_* API
   wrappers in src/sig/sig.c (keypair, sign, sign_with_ctx_str,
   verify, verify_with_ctx_str).
2. Switch all SIG constructors (including the SLH-DSA template
   and the copy_from_upstream jinja template) from OQS_MEM_malloc
   to OQS_MEM_calloc so any unset function pointer is guaranteed
   NULL, making the API NULL check reliable.

For SIG_STFL:
- The API wr... (continued)

Coverage Stats

275 of 287 new or added lines in 259 files covered. (95.82%)

28 existing lines in 10 files now uncovered.

207634 of 252661 relevant lines covered (82.18%)

8208894.9 hits per line