agama-project / agama / 27423962223

83%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): UI fixes and improvements (#3613)

This PR improves form consistency, navigation, and user guidance across
the web UI. It standardizes form actions, provides clearer feedback
after submission, and fixes a minor UI issue with the header.

As part of an effort to unify form behavior across the application,
form-level **Cancel** actions now consistently navigate back to the
previous page. This pattern applies also to pages that are themselves
forms (system, authentication, registration, product selection, etc.),
rather than summary or overview pages that serve as navigation hubs to
other sections.

## Changes

* **Refactor system settings form**

  * Uses shared form handling for consistency with other forms
  * Keeps the form testable independently from the page wrapper

* **Improve post-submit feedback**
* Success and no-changes alerts now include a link back to the
installation summary
 
* **Standardize form Cancel actions**

* Add Cancel buttons to the system, authentication, and registration
forms
  * Use back navigation for the product selection Cancel action
  * Align form navigation behavior across the application

 
* **Fix color scheme leftover in the config dialog**

* The JSON code editor now uses its dark theme when dark mode is active

 
* **Fix header toolbar interaction**

* Prevents empty toast containers from blocking clicks on header actions

## Test Plan

* [ ] System settings form: submit changes, no changes, invalid data,
and cancel
* [ ] Authentication and registration forms: cancel button navigates
back
* [ ] Form submission alerts include a link to the installation summary
* [ ] Product selection: cancel navigates to the previous page
* [ ] Header toolbar remains clickable when no toast notifications are
displayed
* [ ] Config dialog: code editor follows the selected color scheme
(light/dark/system)

Coverage Stats

4466 of 6543 branches covered (68.26%)

Branch coverage included in aggregate %.

26 of 27 new or added lines in 6 files covered. (96.3%)

10 existing lines in 6 files now uncovered.

24266 of 28741 relevant lines covered (84.43%)

109.1 hits per line