SwissDataScienceCenter / renku-data-services / 27335489877

86%

push

github

feat: automatic resource pool viewer access via OAuth2 provider linkage (#1315)

* feat: sync resource pool viewer access on OAuth2 connect and disconnect (#1317)

* feat: sync RP access on OAuth connect/disconnect

Add _on_oauth2_connected and _on_oauth2_disconnected helpers
that auto-grant/revoke viewer access to resource pools linked
to the provider. Wire member_repo through constructors.

5 new tests cover: connect grant, disconnect revoke, no-match
no-op, multi-user grant, isolated disconnect.

* feat: trigger RP sync in OAuth flows

Call _on_oauth2_connected after successful fetch_token in authorize
callback. Call _on_oauth2_disconnected before deleting connection row.
Add test verifying delete_oauth2_connection revokes RP access.

* fix: wire member_repo and fix types

- Fix forward reference in dependencies.py by initializing
  connected_services_repo without member_repo and setting it later
- Add user_id/client_id to OAuth2Connection model for type safety
- Guard blueprint callback against None values
- Remove debug logging from _on_oauth2_connected

* chore: logging

* fix: ensure session deletion, remove repetition

* chore: public naming for on_oauth2*

* refactor: remove need for `| None` annotation

* refactor: apply changes in rp memberships in one go

* feat: transmit sessions

* fix: one session per authz op

* fix: remove useless session

* feat: auto-grant/revoke resource pool viewer access on CRUD based on OAuth2 provider linkage (#1314)

* chore: feature branch

* feat: inject MemberRepository into ResourcePoolRepository + add failing tests for RP remote provider sync

- Add member_repo parameter to ResourcePoolRepository constructor
- Wire member_repo in dependencies.py and test/utils.py
- Add TDD tests for auto-grant/revoke on RP CRUD operations

* feat: add helper to query connected users by provider_id

Adds _get_connected_user_ids to ResourcePoolRepository for fetching
users with a connected OAuth2 link to a given provider.

... (continued)

165 of 193 new or added lines in 6 files covered. (85.49%)

27060 of 31338 relevant lines covered (86.35%)

1.5 hits per line