SwissDataScienceCenter / renku-data-services / 27287752838
86%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
27287752838

push

github

web-flow 
Refactor: improve image accessibility checks (#1333)

* fix(tests: add missing fixture for anonymous session tests

Amalthea is required and it would not work if test is run
in isolation or from the file.

* fix: do not return private image pull secret if user is anonymous

* refactor: use forbidden error when repository is not accessible

* refactor: rewrite session starting test to check more use cases

It now tests both user and anonymous user with builds enabled
and disabled.

* chore: user forbidden when trying to start a session without pull permissions

* refactor: improve conditions when checking from private builds

* fix(test): make private repo not accessible to anonymous

* feat(test): add builds specific session start tests

* refactor: move image checking to image_check

The checks done when starting a session have been moved to
the ImageCheckRepository class so that it can be done from
anywhere an image check is required.

Initial implementation adds that to the current Image based
check

* refactor(test): ensure BuildsConfig is coherent

enabled is not enough as depending on which parameters
are passed to the tests the rest of the configuration
might change such as the private image prefix.

* fix: handle none gitlab_user when checking image accessibility

Based on mypy output

* fix: update check_image call to take into account new signature

* refactor: add launcher id as possible input for docker image check endpoint

Using the launcher id allows for the full check of image availability
as is done when starting a session.

New parameter added to avoid backward incompatible changes.

* chore: cleanup after rebase

* chore(devcontainer): update k9s version

* refactor: do not make image_check raise exceptions

* refactor: sessions must always start

The current rules are the following:

- if the user is anonymous, do not add any ImagePullSecret: this is the existing
  behavior. => If the image is not publicly accessible, the image can... (continued)
Source Files on build 27287752838
Detailed source file information is not available for this build.