kobotoolbox / kpi / 27365497735

82%

master: 76%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(formMedia): orvalify component DEV-2176 (#7135)

### 💭 Notes

Migrated FormMedia component from legacy Reflux actions to React Query
with orval-generated API endpoints.

Changes here:

**Backend - OpenAPI Schema:** (AI assisted)
- `kpi/views/v2/asset_file.py` - Added missing `file_type` query
parameter to the files list endpoint docs (backend already supported it,
just wasn't in the schema)
- `kpi/schema_extensions/v2/files/serializers.py` - Refactored
CreateFilePayload to use PolymorphicProxySerializer for cleaner union
types
- `static/openapi/schema_v2.{yaml,json}` - Regenerated schemas with the
file_type parameter

**Frontend - Component Migration:**
- `jsapp/js/project/FormMedia/index.tsx` - Replaced Reflux actions
(`actions.media.*`) with React Query hooks (`useAssetsFilesList`,
`useAssetsFilesCreate`, `useAssetsFilesDestroy`)
- Now uses `useIsMutating` with a custom mutation key to track
concurrent file uploads separately from URL uploads (since drag-and-drop
can upload multiple files at once)
- Ditched the custom `usePendingUploads` hook in favor of React Query's
state
  - Field-level error handling now works inline
  
**Frontend - Type Safety:**
- `jsapp/js/api/mutation-defaults/survey-data.ts` - Global mutation
defaults for cache invalidation
- `jsapp/js/endpoints/formMedia.mocks.ts` - Updated MSW handlers to
match orval types

**Testing:**
- `jsapp/js/project/FormMedia/FormMedia.stories.tsx` - Stories pass with
updated mocks

No reflux bridge routes needed since all `actions.media.*` consumers
were already migrated.

### 👀 Preview steps

1. Have a deployed project with a form
2. Go to **Project → Form → Media**
3. **File uploads:**
   - Drag 2-3 files into the dropzone at once
   - Should show "Uploading file…" while they're going up
   - Files show up in the list when done (no refresh)
4. **URL uploads:**
   - Paste a URL (like `https://example.com/image.png`) into the input
   - Click "Add"
   - Should appear in the list with a li... (continued)

Coverage Stats

9035 of 12268 branches covered (73.65%)

20 of 29 new or added lines in 4 files covered. (68.97%)

2 existing lines in 1 file now uncovered.

29665 of 36357 relevant lines covered (81.59%)

5.56 hits per line