openbraininstitute / libsonata / 27352019973

93%

push

github

Move electrodes_file to per-report LFP blocks (#49)

Implements the spec change that moves `electrodes_file` from the global `run` section to individual LFP report 
blocks, and makes `variable_name` optional for LFP reports.

Fix: #50 

More discussion in: https://github.com/openbraininstitute/sonata-extension/pull/34

## Changes

- **Report struct**: Added `electrodesFile` field to `SimulationConfig::Report`
- **Run struct**: Removed `electrodesFile` field from `SimulationConfig::Run`
- **Parser**: `parseRun()` now rejects `electrodes_file` with a helpful migration message; `parseReports()` handles per-report parsing for LFP and rejects it for non-LFP types
- **variable_name**: Now optional for LFP reports (LFP always uses i_membrane)
- **Python bindings**: `electrodes_file` moved from `SimulationConfig.Run` to `SimulationConfig.Report`
- **Tests**: Updated existing tests, added new unit tests and property-based tests

## Breaking Changes

- `SimulationConfig.Run.electrodes_file` no longer exists (Python)
- `SimulationConfig::Run::electrodesFile` no longer exists (C++)
- Configs with `electrodes_file` in the `run` section will now throw an error with migration guidance

## References

Spec: sonata-extension branches:

https://github.com/openbraininstitute/sonata-extension/pull/34
https://github.com/openbraininstitute/sonata-extension/pull/35

14 of 21 new or added lines in 1 file covered. (66.67%)

2522 of 2714 relevant lines covered (92.93%)

50.9 hits per line