pirl-unc / hitlist / 27345169321
80%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 29
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 79.788%. Remained the same
27345169321

push

github

web-flow 
v1.40.2: remove 9 low-value tests that exercise no hitlist code (#337)

An audit of the ~19k-line test suite surfaced 9 tests that either run zero
production code (they test third-party libraries) or assert nothing a sibling
test doesn't already cover. Removing them drops noise without losing coverage.

Tier 1 — exercise zero hitlist code:
- test_builder.py::test_pyarrow_concat_preserves_categoricals_round_trip
  (tests pyarrow's own DictionaryArray round-trip; the builder's real concat
  path is covered by build_observations + test_build_smoke).
- test_builder.py::test_pyarrow_from_pandas_handles_mixed_pmid_after_normalization
  (re-implements the builder's pmid→Int64 normalization inline, then tests
  pa.Table.from_pandas; the real per-partition normalization is inline in
  build_observations and covered end-to-end there).
- test_export.py::test_cli_list_args_accept_space_and_comma_and_repeated_forms
  (builds a throwaway argparse.ArgumentParser and tests stdlib extend/nargs;
  cannot catch a regression in the real CLI flags).
- test_supplement.py::test_supplement_mhc_species_fallback_pattern_handles_categorical
  (inlines a pandas fillna idiom — docstring even says "unit test of the
  idiom" — and guards a scenario the production path never reaches).

Tier 2 — run real code but assert nothing meaningful / duplicate a sibling:
- test_export.py::test_ms_samples_table_not_empty (assert len > 0 only).
- test_export.py::test_generate_observations_table (column-existence only;
  values are asserted by the sibling provenance/instrument/chimeric tests).
- test_observations.py::test_is_binding_built_bool and
  ::test_is_built_false_initially (isinstance(bool) on `return path.exists()`
  one-liners — cannot fail; the real not-built branch is covered by
  test_load_observations_not_built).
- test_curation.py::test_classify_ms_row_backward_compat (identical call +
  assertion to test_cell_line_is_cancer).

Drop the now-unused is_binding_built import from test_... (continued)

5570 of 6981 relevant lines covered (79.79%)

0.8 hits per line

Jobs
ID Job ID Ran Files Coverage
1 27345169321.1 29
79.79
 GitHub Action Run
Source Files on build 27345169321