decentraland / catalyst-storage / 27282131930

95%

push

github

fix: decouple decompression cap default from cache size (256MB) (#103)

decompressMaxFileSize defaulted to decompressCacheMaxSize (5GB), conflating
a per-file inflation cap with the whole-cache budget. That let a single
decompression write up to 5GB before aborting — still a meaningful disk/CPU
DoS, and a single file could fill the entire cache.

Default it to a dedicated 256MB instead: well above any realistic single
compressible content file (a whole world's budget is ~100MB) while bounding
a malicious gzip to a small footprint. Still overridable via the option.

Updates the default-cap tests to assert the per-file cap is now independent
of decompressCacheMaxSize, and that an explicit cap still overrides it.

106 of 119 branches covered (89.08%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

368 of 375 relevant lines covered (98.13%)

34.6 hits per line