Unleash / unleash / 27275380712

87%

master: 91%

push

github

feat: Support filtering feature search by the `archived` lifecycle stage (#12260)

### What

Lets the feature search endpoint (`GET /api/admin/search/features`)
return archived flags via the `lifecycle` query param.
`lifecycle=IS:archived` now returns archived flags (equivalent to
`archived=IS:true`), and — crucially — the `archived` stage can be
combined with active stages in a single request, e.g.
`lifecycle=IS_ANY_OF:live,archived` returns live **and** archived flags
together.

### Why

Previously the only way to see archived flags in search was the
dedicated `archived=IS:true` param, which is strictly one-or-the-other
(active **xor** archived). There was no way to ask for "live flags plus
archived flags" in one query. Treating `archived` as a lifecycle stage —
which it already is in our model (`StageName`) — fills that gap and
makes the search filter match how users think about the flag lifecycle.

Sending `lifecycle=IS:archived` on its own used to return nothing: the
always-on active-only filter (`archived_at IS NULL`) silently cancelled
the lifecycle clause. This fixes that.

### How

The change centers on `feature-search-store.ts`, where two filters
previously collided — the always-on `filterByArchived` (defaulting to
active-only) and the lifecycle `whereIn`. They're now reconciled in a
single `applyLifecycleAndArchivedFilters` helper:

- The `archived` stage resolves to the canonical `features.archived_at
IS NOT NULL`, **not** `latest_stage = 'archived'`. This keeps it
identical to `archived=IS:true` and catches legacy flags archived before
lifecycle tracking existed (which have no `archived` lifecycle row).
- Inclusion (`IS` / `IS_ANY_OF`): `latest_stage IN (active stages) OR
archived_at IS NOT NULL` when archived is requested; otherwise
active-only.
- Exclusion (`IS_NOT` / `IS_NONE_OF`): excludes the listed active stages
and never surfaces archived flags.
- No `lifecycle` param → unchanged behaviour
(`filterByArchived(archived)`).

Lifecycle... (continued)

1876 of 2067 branches covered (90.76%)

38 of 39 new or added lines in 2 files covered. (97.44%)

15212 of 17410 relevant lines covered (87.38%)

910.65 hits per line