Ouranosinc / xclim / 27222553321

92%

push

github

Default values for dc0 and dmc0 when dry start is activated (#2372)

<!--Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes #2371
- [x] Tests for the changes have been added (for bug fixes / features)
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features)
- [x] CHANGELOG.rst has been updated (with summary of main changes)
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added

### What kind of change does this PR introduce?

* Adds a default value to `DC` and `DMC` when the dry start is
activated. The idea of dry start is to increase the starting values of
these during dry winter days, so it didn't make sense to start at NaN
and only perform the dry start mechanism after the first season.

### Does this PR introduce a breaking change?
Yes, values have changed, but this is quite niche.

### Other information:
The test is very simple, but I don't think we have canonical data for
this specific case.

3 of 3 new or added lines in 1 file covered. (100.0%)

7940 of 8643 relevant lines covered (91.87%)

6.27 hits per line