ben-manes / caffeine / #5512

100%

master: 100%

push

github

Fix self-suppression, a Pacer read race, and async getIfPresent stats

Three latent issues surfaced by the audit-temporal-walk history audit:

* Pacer.isScheduled() read the non-volatile `future` field twice, so a
  concurrent maintenance cycle nulling it (Pacer.cancel) between the two
  reads could throw a NullPointerException out of the lock-free cleanUp()
  fast path. Snapshot the field into a local.

* AsyncBulkCompleter.fillProxies/addNewEntries aggregated per-entry
  weigher/expiry failures with an unguarded error.addSuppressed(t). A
  weigher or expiry that throws the same instance on more than one entry
  of a bulk async load made the second call error.addSuppressed(error),
  which Throwable rejects with IllegalArgumentException -- masking the real
  failure and leaking the proxy futures left unvisited. Guard with
  `error != t`, matching the JDK try-with-resources idiom; the same guard
  is applied to CacheProxy.tryClose.

* The async synchronous view's getIfPresent recorded a hit for an in-flight
  future while returning null. Record a miss instead, consistent with
  getAllPresent and the "in-flight is logically absent for queries" model.

4040 of 4048 branches covered (99.8%)

12 of 12 new or added lines in 3 files covered. (100.0%)

8227 of 8227 relevant lines covered (100.0%)

1.0 hits per line