code-shoily / choreo / 1b2cfdfeccdba0a6faa0a30631c3da998e3ab221

88%

Build Type

push

github

Committed by web-flow

Commit Message

Hardening phase 2 (#2)

* refactor: Align Choreo and Choreo.Infrastructure data models, unify rendering

This commit addresses the architectural drift between top-level Choreo and
Choreo.Infrastructure identified in code review.

Key changes:

- Standardize node data keys across both modules:
  - :type → :node_type (aligns with C4, Planner, Workflow, etc.)
  - :name → :label (display name convention)

- Extend top-level Choreo with cloud primitives:
  - New node builders: add_internet/3, add_compute/3, add_managed_db/3
  - New cluster builders: add_vpc/3, add_subnet_public/3, add_subnet_private/3
  - Typed clusters carry :cluster_type metadata for theme-aware rendering

- Make Choreo.Infrastructure a thin vocabulary wrapper:
  - Delegates rendering to Choreo.Render.DOT and Choreo.Render.Mermaid
  - Deleted parallel renderers (Infrastructure.Render.DOT/.Mermaid)
  - Fixes the embed/4 interoperability bug where embedded infra nodes
    rendered as generic shapes

- Move cluster-type styling into shared Choreo.Render.DOT:
  - VPC (dashed), public subnet (green), private subnet (red) defaults
  - Dark-theme variants supported

- Fix Infrastructure.Analysis:
  - Renamed warnings/1 → validate/1 (returns [{severity, msg}])
  - Severity distinguishes :error (critical) from :warning
  - Added storage-public-subnet and unassigned-compute checks

- Fix zoom predicates to include databases at tier 1

- Fix DOT renderer highlight logic for nodes and edges

- Update README/guides to clarify Choreo vs Infrastructure usage

* Apply Planner review fixes (hardening-phase-2)

- Fix @spec return types on Analysis functions (Yog.node_id() not Planner.t())
- Fix Quick Start example ready/1 status (:impl now :backlog)
- Fix zoom_predicate arity to 2-arity (id, data) consistently across all modules
- Fix new/1 to accept keyword opts while keeping backward compat
- Add parents/2 and assignees/2; make parent/2 and assignee/2 convenience wrappers
- Fix relates/3 to raise Argume... (continued)

Coverage Stats

239 of 312 new or added lines in 18 files covered. (76.6%)

11 existing lines in 4 files now uncovered.

5137 of 5843 relevant lines covered (87.92%)

20.58 hits per line