code-shoily / choreo / 6d458c895cd0affd53e5d9f9cdc587ffc93cf8a2

88%

push

github

fix(uml,erd): review fixes for cycles, strict mode, zoom, and shared helpers

Joint fixes:
- Extract duplicated dfs_cycles/1 and normalize_cycle/1 from UML.Analysis
  and ERD.Analysis into Choreo.Internal.dfs_cycles/1
- Fix cycles/1 docstrings to match actual return (canonical node list,
  not closed cycle)
- Implement real zoom_predicate levels for UML (0=contracts, 1=+class,
  2+=all) and ERD (0=tables with relationships, 1+=all)
- Add strict: mode to UML.new/1 and ERD.new/1; add_relationship/4 raises
  on missing endpoints when strict is true
- Fix broken markdown tables in both livebooks (escaped pipes inside cells)
- Add hex/local Mix.install labels, Kino.Layout.tabs, and polish

UML-specific:
- Tighten field/function :name schema to {:or, [:atom, :string]} and
  normalize to string at storage time
- Extract unsatisfied_contract/3 helper shared between add_relationship/4
  (build-time strict check) and broken_contracts/1 (post-hoc analysis)
- Fix broken_contracts/1 doctest to avoid keyword-order dependency
- Fix virtual_edge_meta label from "virtual" to nil
- Fix cheat sheet: View.focus/2 -> /3

ERD-specific:
- Change one_to_one penalty default from 5 to 0 (opinionated; users can
  opt-in via weights)
- Add Analysis.validate/1 for API consistency with other modules
- Fix normalization_score string interpolation via inspect/1 consistently
- Document column-matching opt-in behavior
- Document Mermaid theme limitation
- Fix "Cheat Sheet Cheat Sheet" typo

47 of 55 new or added lines in 5 files covered. (85.45%)

5136 of 5771 relevant lines covered (89.0%)

20.07 hits per line