karellen / kubernator / 27163073273

82%

push

github

Fix test-only JSON patches treated as non-empty mutations (#108)

## Summary

- **Bug:** `_filter_resource_patch` always preserves `test` ops
(uid/resourceVersion guards), so when all mutation ops are filtered out
or absent, the patch list is still truthy. This causes spurious
"Patching resource" log entries in dump mode and unnecessary no-op PATCH
API calls in apply mode.
- **Fix:** Track whether any mutation (non-`test`) ops survive
filtering. Return an empty list when only `test` ops remain, since
test-only JSON Patches are no-ops.
- **Tests:** Added `k8s_filter_patch_tests.py` covering: test-only patch
returns empty, mutations preserved with tests, all mutations excluded
returns empty, partial exclude preserves remaining, empty input returns
empty.

## Test plan

- [x] All existing unit tests pass (`pyb -vX run_unit_tests`)
- [x] New `k8s_filter_patch_tests.py` covers the fix

1081 of 1496 branches covered (72.26%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

4443 of 5232 relevant lines covered (84.92%)

4.23 hits per line