jandelgado / jled / 27162399366

99%

push

github

make candle effect stateless (#154)

The old candle effect was stateful, which violated the architecture principle that effects should be stateless. This resulted in the largest memory footprint of all effects at 12 bytes. Since we use a discriminated union, the candle effect, being the largest, determined the size of the effect buffer in the TJLed class. The refactoring reduces this to 6 bytes, making the Breathe effect with 8 bytes the largest member. This saves 4 bytes on every JLed object. 

Additionally, the brightness lookup table was reworked to include a gamma value of 2.2, resulting in better visual fidelity.

* bump cpplint to 2.0.2
* fix "version hint" removal

90 of 100 branches covered (90.0%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 2 files covered. (100.0%)

362 of 365 relevant lines covered (99.18%)

848.11 hits per line