iotaledger / iota-rust-sdk / 27111689821
36%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 179
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 40.238% (+0.05%) from 40.185%
27111689821

push

github

web-flow 
feat!: separate Event and GraphQlEvent types (#1184)

* fix(ffi): split GraphQL event from core chain Event

The FFI `Event` struct conflated two concepts: a GraphQL-sourced event
(optional sender/module, plus data/json/timestamp) and the core chain
`iota_sdk::types::Event` (all fields required, BCS/JSON serializable).
The GraphQL->Event conversion `.unwrap()`d on sender/module/timestamp,
panicking on system events (e.g. 0x3::validator::StakingRequestEvent),
and the Event->core conversion silently defaulted missing fields to
ZERO/empty while `.unwrap()`ing an invalid empty `Identifier`.

Split into two types:
- `GraphQlEvent`: faithful, non-lossy view of the GraphQL `events`
  query result, with optional package_id/module/sender/timestamp.
- `Event`: mirrors `iota_sdk::types::Event` 1:1 with required fields.

The core conversion is now `TryFrom`, so `event_to_bcs`/`event_to_json`
(and the `TransactionEvents`/`GenesisTransaction` constructors) fail
cleanly instead of panicking or producing zeroed output. Binding
examples updated to handle the now-optional sender/module.

* chore(ffi): clarify optional event field comment in examples

Sender/module are null for system- and genesis-emitted events (sender
0x0), not for the StakingRequestEvent type per se.

* chore(ffi): clarify GraphQlEvent doc on optional fields

Match the example comments: sender/module are null for system- and
genesis-emitted events (sender 0x0), not the StakingRequestEvent type.

* chore(ffi): generalize optional event field comment in examples

Drop the StakingRequestEvent reference (the examples query a user event
that always has sender/module); just note some events omit them.

* fix(go-example): deref double pointer for optional event sender

uniffi-bindgen-go renders Option<Arc<Address>> as **Address, so the
optional GraphQlEvent.Sender needs an extra deref before calling ToHex.

* refactor(ffi): make GraphQlEvent non-lossy and move it to graphql module

- Make the GraphQL Event ... (continued)

9198 of 22859 relevant lines covered (40.24%)

9665.36 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
71.25
 -1.06% crates/iota-sdk-types/src/object.rs
3
26.88
 -3.23% crates/iota-sdk-types/src/crypto/ed25519.rs
2
83.77
 -1.3% crates/iota-sdk-types/src/crypto/passkey.rs
1
70.93
 -0.22% crates/iota-sdk-types/src/crypto/signature.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest - 27111689821.1 179
40.24
 GitHub Action Run
Source Files on build 27111689821