jandelgado / jled / 27091990259

97%

master: 98%

Build Type

Pull #154

github

Committed by jandelgado

Commit Message

make candle effect stateless 

the old candle effect was stateful (which was against our architecture,
stating that effects should be stateless), which resulted in the largest
memory footprint of all effects (12 bytes). since we use a discriminated
union, the candle effect, having the largest memory footprint, was
determining the size of the effect buffer in the TJLed class. The
refactoring now uses just 6 bytes, and the Breathe effect with 8 bytes
is now the largest member. Overall we save 4 bytes on every JLed object.

Also the brightness lookup table was re-worked to include a gamma value
of 2.2, resulting in a better visual effect.

Pull Request Pull Request #154: make candle effect stateless

Coverage Stats

91 of 100 branches covered (91.0%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

366 of 369 relevant lines covered (99.19%)

838.73 hits per line