moonbitlang / core / 4633

94%

push

github

warnings: enable unnecessary_view_op, drop redundant `[:]` views

Adds `+unnecessary_view_op` to the workspace warn-list and drops the
unnecessary `[:]` view conversion at every site the lint flags
(~111 sites in `builtin/string_methods.mbt`, `builtin/arrayview*`,
`builtin/readonlyarray*`, `builtin/array*`, `debug/printer.mbt`, etc.).

In two ReadOnlyArray methods (`filter`, `filter_map`), only the outer
`[:]` was removable; the inner `self[:]` is kept because removing it
recurses into the same method (`ReadOnlyArray::filter`/`filter_map`)
instead of dispatching to `ArrayView::filter`/`filter_map`. The lint
flagged both but only one is genuinely unnecessary.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

5 of 7 new or added lines in 4 files covered. (71.43%)

14958 of 15872 relevant lines covered (94.24%)

207068.03 hits per line