rm-hull / dot-block / 27071970778

61%

push

github

fix: separate dial and read timeouts for upstream connections (#139)

* fix: separate dial and read timeouts for upstream connections

- Replaced `--connection-timeout` with `--dial-timeout` and
`--read-timeout` to allow finer control over connection establishment
versus response wait times.
- Updated `ConnPool` to use an explicit `net.Dialer` for dialing.
- Adjusted default timeout values to 300ms for both operations.

* feat: support upstream DNS without explicit port

- Update upstream configuration to assume port 53 if omitted.
- Add `resolveUpstream` helper to resolve and normalize addresses.
- Update documentation and default values to reflect the change.
- Refactor telemetry latency logging to use string representation.
- Fix style inconsistencies in `ConnPool` struct definition.

* fix: record failed pooled connections

Ensure pooled connection failures are tracked in metrics before
abandoning the connection, improving observability into pool health.

* feat: add write-timeout configuration for DNS upstream

- Added `--write-timeout` CLI flag with a default of 500ms.
- Updated `dns.Client` configuration to explicitly set `WriteTimeout`,
`ReadTimeout`, and `DialTimeout`.
- Refactored `ConnPool` to use the client's built-in dialer for cleaner
connection management.

24 of 37 new or added lines in 4 files covered. (64.86%)

799 of 1686 relevant lines covered (47.39%)

1027.35 hits per line