MushroomObserver / mushroom-observer / 27060880959

98%

push

github

Phlexify _section_update.erb: extract ApplicationController::SectionUpdater (#4459)

Replaces the `observations/show/_section_update.erb` partial
that was rendered by 5 controllers
(collection_numbers, herbarium_records, sequences,
external_links, namings/votes) after their CRUD actions to
broadcast two turbo_stream actions in one response:

- `replace` the `#observation_<identifier>` sub-panel container
  with the obs-show panel's Phlex view
- `update` the `#page_flash` div with the controller's flash
  messages

New: `ApplicationController::SectionUpdater` module with
`render_obs_section_update(identifier:, panel:)` private method
that issues `render(turbo_stream: [...])` with the two actions.
Included into `ApplicationController` so all 5 controllers see
it for free.

Each `render_<thing>_section_update` private method (5 total)
becomes a 4-6 line call: pick the Phlex panel class, instantiate
with the controller's ivars, hand to the shared helper. The
identifier-to-panel-class dispatch that lived in the ERB now
lives at each controller's callsite where the panel class is
already in scope.

`assert_template("observations/show/_section_update")` in 2
controller tests → selector assertions on the emitted
`turbo-stream[target='...']` elements per the phlex-conversions
rule.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

12 of 12 new or added lines in 7 files covered. (100.0%)

43760 of 45061 relevant lines covered (97.11%)

761.96 hits per line