dangernoodle-io / breadboard / 27047923201

100%

push

github

fix(bb_diag): defer panic-tap arm + preserve crash log across the recovery boot (B1-226) (#349)

- arm the log-stream tap at the top of bb_diag_panic_init (after clearing
  the RTC buffer) so early-phase crashes during the recovery boot are
  captured to the fresh record
- extract bb_diag_panic_order_copy() — pure circular-buffer flattening
  helper (buf/length/write_pos → flat ordered bytes); no global state,
  fully host-testable; declared in bb_diag.h
- copy the crash log into s_panic_log_serve[] before the RTC buffer reset
  and tap re-arm, so /api/diag/panic returns the crash boot's log tail
  instead of the recovery boot's (the root cause of B1-226)
- rewrite bb_diag_panic_get() to serve from s_panic_log_serve (already
  ordered, plain memcpy + NUL); no longer reads live s_panic_rec
- bb_diag_panic_clear() also zeroes s_panic_log_serve_len
- host stub implements bb_diag_panic_order_copy() for test coverage
- 9 new host tests cover: not-wrapped, wrapped, full write_pos=0, empty,
  truncation (linear), truncation (wrapped), null buf, null out, out_cap=1

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

1386 of 1386 branches covered (100.0%)

Branch coverage included in aggregate %.

2348 of 2348 relevant lines covered (100.0%)

938.91 hits per line