Qiskit / qiskit / 27032377058

87%

Build Type

push

github

Committed by web-flow

Commit Message

Make Optimize1qGatesDecomposition multithreaded (#15567)

* Make Optimize1qGatesDecomposition multithreaded

This commit switches to make optimize1qgatesdecomposition a parallel
transpiler pass. After we collect the 1q runs in the dag the step of
computing the unitary matrix for each run and synthesizing it has no
data dependency and can be run in parallel without issue. However
updating the dag with synthesis results is still serial so there are
limits to how much can be parallelized here. Additionally, in the
previous serial version the target euler bases to try were computed
eagerly the first time a qubit with a run was encountered. This would
force a data dependency between the threads which either require
locking or precomputing the target bases, which is what this commit does.
This means that instantiating the pass object is slower and we're
potentially doing more work up front than is strictly necessary. However
this does have the advantage of being amortizable over multiple
executions of the pass which before it was not.

A quick experiment was run to determine that when there are roughly
100,000 runs to process (all runs of 20 gates) is the crossover point for the
parallel version vs the serial version. This was used to set a run count
that is used to select between a serial and parallel version of the algorithm.

* Rework eager pre-initialization to be lazy again

This commit reworks the change in logic from the previous commit to no
longer pre-compute the euler basis set for each qubit regardless of
whether it's used or not. The state object used to store the basis gates
and euler basis sets is kept as this enables more efficient patterns on
multiple runs of the pass. Now the state uses OnceLock to enable each
thread to lazily populate the state on the first run of a qubit. This
saves the construction time overhead if qubits never have runs but
keeps the advantages of reused state.

* Revert 100,000 crossover value and leave as TODO

In ear... (continued)

Coverage Stats

235 of 308 new or added lines in 5 files covered. (76.3%)

16 existing lines in 5 files now uncovered.

109254 of 124941 relevant lines covered (87.44%)

958004.01 hits per line