Qiskit / qiskit / 27041447297

88%

Build Type

push

github

Committed by web-flow

Commit Message

Consolidate `Target` mappings (#15349)

* Initial: Clean up target mappings
The following commits remove the redundant mappings `gate_name_map` and `angle_bounds` in favor of one mapping with a struct that contains all of that data. This results in a much lighter `Target` going from 504 (0x1F8) bytes to 288 bytes.

The new struct called `TargetProperties` is currently internal-only. And contains three fields.
- `properties` containing the mapping of the qargs and instruction properties (originally the `gate_map`).
- `instruction` containing the `TargetOperation` (originally the `gate_name_map`).
- `angle_bounds`: Optionally containing the angle bounds for the ``Target`` (originally `angle_bounds`.)

This is the first effort to more efficiently use the ``Target`` in Rust with upcoming efforts focusing on its behavior on Python.

* Fix: Remove clippy unused

* Fix: Address review comments
- Replace ambiguous type declarations with more explicit types.
    - `PropsMap` to `TargetIndexMap<K,V>` == `IndexMap<K,V,RandomState>`.
- Make `TargetProperties` private.
- Remove `_raw_operation_from_name`.
- Use `IndexMap::with_capacity_and_hasher` during deserialization.
- Revert overusage of `&str`.

* Refactor: Remove type alias.
- In cases where the alias of `IndexMap<String, TargetProperties, ahash::RandomState>` looked too long, I matched it to the `Index` trait whose return `Output` value is already of said type.

* Fix: unused Barrier import in test_target.py

Coverage Stats

128 of 160 new or added lines in 2 files covered. (80.0%)

31 existing lines in 4 files now uncovered.

109284 of 124981 relevant lines covered (87.44%)

957572.31 hits per line