tarantool / go-tarantool / 27026007049

76%

master: 75%

Build Type

Pull #589

github

Committed by bigbes

Commit Message

api: redesign errors around errors.Is and errors.As

Rename tarantool.Error to ServerError, promote the seven legacy uint32
client error codes to package-level error sentinels (ErrConnectionClosed,
ErrTimeouted, ...) and expose their numeric form as iproto.Error
constants (CodeConnectionClosed, ...), the same type carried by
ServerError.Code, so client and server codes compare without
conversion. ClientError gains a Cause field plus Unwrap() []error so
errors.Is matches the sentinel and errors.As reaches the underlying net
error. Retryability is expressed as a sentinel (ErrRetryable) joined
into the chain; IsRetryableError wraps errors.Is, and each code is
documented with whether the request is safe to repeat. The deprecated
Temporary() method is removed.

Internal callers in connection.go, dial.go and response.go switched to
newClientError / ServerError detection; I/O failures now wrap the
original error instead of stringifying it. Tests and examples in box,
arrow, pool, and the root package were migrated from type assertions to
errors.As / errors.Is.

Also fixes a pre-existing %x formatting bug on iproto.Error in
ServerError.Error(); ClientError.Error() formats its code the same way.

Closes #469

Pull Request Pull Request #589: api: redesign errors around errors.Is and errors.As

Coverage Stats

63 of 97 new or added lines in 4 files covered. (64.95%)

2 existing lines in 1 file now uncovered.

3131 of 4146 relevant lines covered (75.52%)

9892.55 hits per line