dangernoodle-io / TaipanMiner / 26996814088

90%

push

github

test(webui): stabilize flaky coverage in diagnosticsState and FanEditDialog (#509)

two root causes: (1) diagnosticsState.test.ts called vi.useRealTimers()
for the withRetry 400ms backoff, leaving real async work in flight after
each test — this bled into v8 coverage collection for subsequent test
files and caused statement counts to vary by up to 16 across runs (e.g.
4058–4074); fixed by removing vi.useRealTimers() and using
vi.advanceTimersByTimeAsync(400) to advance fake timers through the
backoff without wall-clock delay. (2) FanEditDialog.test.ts used real
setTimeout(r, 50) waits but the component sets a real 400ms close timer
on save-success, leaving it pending after tests ended; fixed by adding
vi.useFakeTimers() + vi.runAllTimersAsync(). vitest.config.ts also sets
fileParallelism:false as belt-and-suspenders so cross-file timer bleed
cannot corrupt v8 coverage merging even if a future test regresses.
coverage is now identical across 6 consecutive runs (93.71% statements,
82.47% branches, 91.01% functions, 96.60% lines)

2803 of 3502 branches covered (80.04%)

Branch coverage included in aggregate %.

5461 of 5634 relevant lines covered (96.93%)

146607.16 hits per line