futpib / slopd / 26988541275

86%

push

github

feat: fail `run` fast with a clear message when the executable is missing

`tmux new-window <missing>` returns a pane id even when the command can't
be found, so a typo'd or uninstalled `[run] executable` only surfaced
later as the generic "pane %N died before becoming ready", naming nothing.

Pre-check the executable before spawning (libslop::executable_exists, via
which::which_in) against the pane's effective PATH — a [run.env]/env-file
PATH wins, else slopd's — and working directory, so the lookup matches
what the pane will actually use and absolute paths resolve regardless of
PATH. On failure `run` returns immediately:

  configured executable "<x>" not found — check `[run] executable` ...

Tests: run_fails_clearly_when_executable_does_not_exist,
run_accepts_absolute_path_executable_not_on_path (an absolute executable
whose directory is off-PATH), and an executable_exists unit test. Also
fixes run_injects_hooks_with_absolute_slopctl_path_when_not_on_path, whose
sandbox PATH excluded its own `sleep` executable once `run` started
pre-checking it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

31 of 31 new or added lines in 2 files covered. (100.0%)

4356 of 4997 relevant lines covered (87.17%)

2149013.91 hits per line