futpib / slopd / 26985792068

86%

Build Type

push

github

Committed by futpib

Commit Message

fix: fall back instead of panicking when XDG_RUNTIME_DIR is unset

runtime_dir() did dirs::runtime_dir().expect(...), so a missing
XDG_RUNTIME_DIR crashed slopd/slopctl with a backtrace — including the
`slopctl hook` path that runs inside containers (cron jobs and non-login
ssh hit it too). The XDG Base Directory spec says to fall back to a
replacement directory with similar capabilities and warn, not fail.

Now: prefer /run/user/<uid> if it already exists, else a private 0700
/tmp/slopd-<uid> (uid-keyed so two users don't share a control socket),
with a one-time warning. slopd and slopctl share runtime_dir(), so they
still resolve to the same location. The pure decision is split out into
resolve_runtime_fallback() and unit-tested.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

21 of 44 new or added lines in 1 file covered. (47.73%)

6 existing lines in 3 files now uncovered.

4298 of 4966 relevant lines covered (86.55%)

2162426.21 hits per line