agama-project / agama / 26966766463

83%

push

github

feat(web): improve feedback for download logs action (#3580)

## Problem

Triggering a log download from the installer options menu looked like
nothing happened. There was no feedback until the browser eventually
started the download, which could take a while since log collection
happens server-side.

## Solution

Introduced a `download` utility and a `DownloadFeedback` component that
wrap any downloadable trigger with toast alert feedback.

`InstallerOptionsMenu` adopts `DownloadFeedback` for the "Download logs"
entry. The component wraps the entire menu rather than just the dropdown
item, as PatternFly unmounts dropdown children on close. Wrapping only
the item would cause the pending alert to vanish as soon as the menu
closes.

### Limitations

The success alert is tied to the lifecycle of `DownloadFeedback`. If the
user navigates to another page while the download is being prepared, the
component unmounts and the eventual success alert is lost. The download
itself completes normally, but the user gets no confirmation feedback.

Addressing this properly requires alert state that survives navigation,
which in practice means either a global UI state store or a dedicated
notification context mounted at the app root. The project does not have
either of these yet and evaluating the tradeoffs is out of scope for
this PR.

As a short-term solution, the success alert could be omitted until a
global UI state solution is in place, only if some kind of consistence
between doing nothing and navigating elsewhere is desired.
`DownloadFeedback` already accepts a `successTimeout` prop and can be
straightforwardly extended with a flag to opt out of the success alert
entirely, making it easy to enable later once the infrastructure exists.

## Testing

- Added unit tests for `download` utility and `DownloadFeedback`
component.
- Tested manually.

4425 of 6465 branches covered (68.45%)

Branch coverage included in aggregate %.

42 of 42 new or added lines in 3 files covered. (100.0%)

24028 of 28425 relevant lines covered (84.53%)

97.9 hits per line