iotaledger / iota / 26925129393
67%

DEFAULT BRANCH: develop
Ran
Jobs 1
Files 1075
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 66.98% (-0.06%) from 67.038%
26925129393

push

github

web-flow 
feat: replace `MultiSig` with SDK version (#11505)

This PR is part of the ongoing effort to consolidate blockchain types in
the
canonical `iota-rust-sdk`. Types that are needed by both clients/SDK
consumers
and the node should live in `iota-rust-sdk` and be imported from there,
instead
of being defined twice (once in `iota-types`, once in the SDK).

Following [#11433](https://github.com/iotaledger/iota/pull/11433) for
`ProgrammableTransaction`, this PR replaces the in-house `MultiSig` and
`MultiSigPublicKey` (previously defined in `iota-types::multisig`) with
the SDK
versions. To keep the diff small and avoid touching every call site, the
SDK
types are re-exported from `iota-types::multisig` under the original
names, so
most existing imports continue to work unchanged.

## Description of change

- `iota-types::multisig::MultiSig` is now a re-export of
  `iota_sdk_types::crypto::MultisigAggregatedSignature`, and
  `iota-types::multisig::MultiSigPublicKey` a re-export of
  `iota_sdk_types::crypto::MultisigCommittee`. The companion types
`MultisigMember`, `MultisigMemberSignature`, `BitmapUnit`,
`ThresholdUnit`,
  and `WeightUnit` are also re-exported from `iota-sdk-types`. The local
  `MultiSig { sigs, bitmap, multisig_pk, bytes }` struct and its
  `PartialEq`/`Eq`/`Hash` impls have been removed.
- Signature verification in `impl AuthenticatorTrait for MultiSig` now
goes
through `iota_sdk_crypto::multisig::MultisigVerifier` and reads members
/
  signatures / indices off the SDK type (`committee()`, `signatures()`,
  `get_indices()`) instead of the removed inherent fields. The
  passkey-in-multisig gate keeps the same semantics, now expressed via
  `has_scheme_signatures(SignatureScheme::PasskeyAuthenticator)`.
- API shape changes that callers need to know about:
- `MultiSigPublicKey::new(members: Vec<MultisigMember>, threshold)`
instead of
    `MultiSigPublicKey::new(pks, weights, threshold)`.
  - `MultiSig::new(sigs, pk)` instead of `MultiSig::combine... (continued)

66 of 136 new or added lines in 9 files covered. (48.53%)

647 existing lines in 43 files now uncovered.

152817 of 228154 relevant lines covered (66.98%)

461507.56 hits per line

Uncovered Changes

Lines Coverage ∆ File
40
38.75
 1.1% crates/iota/src/keytool.rs
28
0.0
 0.0% crates/iota-core/src/generate_format.rs
2
81.88
 -0.17% crates/iota-types/src/passkey_authenticator.rs

Coverage Regressions

Lines Coverage ∆ File
203
61.11
 0.85% crates/iota-json-rpc-types/src/iota_transaction.rs
124
82.98
 -0.15% crates/iota-types/src/transaction.rs
65
80.49
 0.0% iota-execution/latest/iota-adapter/src/execution_engine.rs
36
0.0
 0.0% crates/iota-graphql-rpc/src/types/transaction_block_kind/end_of_epoch.rs
28
38.56
 -18.3% crates/iota-types/src/signature.rs
26
74.85
 -1.08% crates/test-cluster/src/lib.rs
16
79.1
 -1.61% iota-execution/latest/iota-adapter/src/execution_mode.rs
11
88.12
 -1.17% crates/iota-network/src/state_sync/mod.rs
11
65.15
 -16.67% crates/iota-stardust-types/src/block/output/token_scheme/simple.rs
10
88.12
 -0.72% crates/iota-test-transaction-builder/src/lib.rs
8
53.69
 -0.57% crates/iota-json-rpc-types/src/iota_object.rs
8
42.86
 -28.57% crates/iota-types/src/collection_types.rs
6
46.9
 -2.65% crates/iota-genesis-builder/src/stardust/types/snapshot.rs
6
79.46
 -5.36% crates/iota-genesis-builder/src/validator_info.rs
6
72.33
 -3.77% crates/iota-json-rpc/src/lib.rs
6
91.85
 -4.44% crates/iota-package-management/src/lib.rs
6
64.67
 -3.59% crates/iota-types/src/iota_system_state/mod.rs
5
55.77
 -9.62% crates/iota-json-rpc-types/src/iota_coin.rs
5
39.6
 -4.95% crates/iota-json-rpc-types/src/object_changes.rs
5
89.43
 -4.07% crates/iota-transaction-builder/src/package.rs
4
88.66
 -1.03% crates/iota-core/src/connection_monitor.rs
4
53.24
 0.0% crates/iota-sdk/src/apis/read.rs
4
60.84
 -2.41% crates/iota-stardust-types/src/block/output/nft.rs
4
0.0
 -80.0% crates/iota-types/src/messages_safe_client.rs
4
81.87
 -0.78% crates/starfish/core/src/network/tonic_network.rs
3
84.72
 -4.17% crates/iota-config/src/transaction_deny_config.rs
3
88.75
 -3.75% crates/iota-genesis-builder/src/stardust/types/address_swap_split_map.rs
3
83.19
 -0.29% crates/iota-json-rpc/src/read_api.rs
3
24.14
 -2.59% crates/iota-json-rpc-types/src/iota_checkpoint.rs
3
57.69
 -2.31% crates/iota-stardust-types/src/block/output/basic.rs
2
95.87
 -0.26% crates/iota-core/src/consensus_adapter.rs
2
0.0
 0.0% crates/iota-core/src/generate_format.rs
2
89.03
 -0.27% crates/iota-network/src/discovery/mod.rs
2
73.81
 -0.29% crates/iota-network/src/randomness/mod.rs
2
38.75
 1.1% crates/iota/src/keytool.rs
2
80.14
 0.47% crates/iota-types/src/crypto.rs
2
89.03
 -0.22% crates/starfish/core/src/commit_syncer/fast.rs
2
91.08
 -0.05% crates/starfish/core/src/header_synchronizer.rs
1
80.82
 0.23% crates/iota-core/src/authority_server.rs
1
91.26
 -0.06% crates/iota-core/src/execution_cache/writeback_cache.rs
1
86.47
 -0.75% crates/iota-network-stack/src/grpc_timeout.rs
1
96.76
 -0.1% crates/starfish/core/src/cordial_knowledge.rs
1
87.84
 0.0% crates/starfish/core/src/leader_timeout.rs
Jobs
ID Job ID Ran Files Coverage
1 nextest+simtest - 26925129393.1 1075
66.98
 GitHub Action Run
Source Files on build 26925129393