tomerfiliba / plumbum / 26892265319

88%

push

github

Fix: SSH bug in windows (#762)

* ssh win fix + test import env case fix

* fix: detect system

Assisted-by: ClaudeCode:claude-opus-4.8
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

* fix: protect against potential issues raising instead of returning False

Assisted-by: OpenCode:Kimi-K2.6
Signed-off-by: Henry Schreiner <henryfs@princeton.edu>

* fix: only drive-letter translate the local scp path

download/upload applied _translate_drive_letter to both src and dst, but
only one side is local. The translation exists so the local cygwin/MSYS
scp binary can parse native c:\... paths; the remote path follows the
remote's conventions and must be passed through verbatim. Translating the
remote side silently corrupted remote POSIX paths containing a colon (a
legal filename char) on Windows hosts using cygwin/MSYS scp.

Now download translates only dst and upload only src. Adds regression
tests asserting which argument is translated.

Assisted-by: ClaudeCode:claude-opus-4.8

---------

Signed-off-by: Henry Schreiner <henryfs@princeton.edu>
Co-authored-by: Suvarna_Narayanan <suvarnanarayanan2g@gmail.com>
Co-authored-by: Henry Schreiner <henryfs@princeton.edu>

1305 of 1762 branches covered (74.06%)

13 of 16 new or added lines in 1 file covered. (81.25%)

5488 of 6288 relevant lines covered (87.28%)

12.35 hits per line