kobotoolbox / kpi / 26875904941

82%

master: 76%

push

github

refactor(formMedia): tsify, functional component, add stories DEV-2175 (#7093)

### 💭 Notes

Form Media was moved to different directory area and modernized to
TypeScript with a functional component, while keeping the same user
workflow for adding, listing, and deleting attached files.

Changes here:
- Component migration:
- Moved Form Media from legacy modal-forms location to the Project
feature area.
  - Converted class component to functional TypeScript component.
- Kept existing media behavior and data flow through current media
actions to avoid a risky backend flow change in this PR.
- UI and structure:
- Replaced BEM component wrappers in this feature with regular JSX and
Mantine layout primitives where practical.
- Preserved warning messages, upload states, URL upload flow, and delete
flow.
- Storybook and testability:
  - Added dedicated Form Media story with a play test that covers:
    - initial list rendering
    - adding media by URL
    - deleting media
- Added dedicated form media mocks and factory helpers for stable story
data.
- Stabilized delete-step assertion by checking media row controls
instead of counting all links on the page.
- Typing and maintainability:
  - Added missing media action typings so actions.media is fully typed.
- Removed duplicated type declarations and reused a single canonical
media action type source.
- Added targeted JSDoc and inline comments to help junior contributors
follow intent and flow.
- Endpoint consistency:
- Updated mocks to use shared endpoint constants from the central
endpoints definition.

### 👀 Preview steps
1. Sign in and open any project that you can edit.
2. Go to Project → Settings → Form Media.
3. Confirm you can see the Attach files area and the existing Attached
files list.
4. Add a file using drag and drop.
5. Add another item using a URL in Paste URL here, then select Add.
6. Delete one attached item using the trash button.
7. Confirm the list updates correctly after each action.
8. O... (continued)

8981 of 12201 branches covered (73.61%)

29482 of 36149 relevant lines covered (81.56%)

5.56 hits per line