lsm / neokai / 26856530284

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat: make codex review bot check opt-in per workflow node (#2054)

* feat: make codex review bot check opt-in per workflow node

- Add requireCodexApproval?: boolean to WorkflowNode, WorkflowNodeInput,
  ExportedWorkflowNode, and NodeDraft types (default false)
- Update gate-features.ts getEffectiveGate/getEffectiveGatePoll to inject
  codex_review_bot script/poll when source node has requireCodexApproval
- Pass workflow to all getEffectiveGate call sites (channel-router,
  space-runtime, node-agent-tools, gate-poll-manager)
- Remove hardcoded features: { codex_review_bot: true } from built-in
  templates (plan-approval-gate, review-approval-gate)
- Preserve existing codex_review_bot gate features during re-stamp for
  backward compatibility with pre-existing workflows
- Add "Require Codex approval" toggle to NodeConfigPanel.tsx
- Update tests to reflect node-level opt-in behavior

* fix: address review feedback on codex opt-in PR

- Persist requireCodexApproval through frontend serialization and backend
  NodeConfigJson/rowToNode/buildNodeConfig
- Add requireCodexApproval: true to built-in Review/Plan Review nodes so
  newly seeded workflows keep codex checks enabled by default
- Pass workflow into all node-agent-tools getEffectiveGate calls (gate
  writes + read_gate) so tool-side evaluation matches channel-router
- Limit codex feature injection to gates with an 'approved' field only,
  preventing accidental override of non-approval scripted gates
- Round-trip requireCodexApproval through export/import (schema + handler)
- Remove now-unused hasGateFeatures import from node-agent-tools

* fix: address second round review feedback on codex opt-in PR

- isApprovalGate now recognizes approvals map fields with match: 'approved'
- maybeInjectCodexFeature skips gates that already have a custom script
- workflowToVisualState preserves requireCodexApproval on NodeDraft load
- evaluateTerminalGateFeatures limited to gates with injected features only
- doesAn... (continued)

Coverage Stats

9940 of 14510 branches covered (68.5%)

Branch coverage included in aggregate %.

574 of 679 new or added lines in 13 files covered. (84.54%)

26 existing lines in 3 files now uncovered.

83655 of 98553 relevant lines covered (84.88%)

295.88 hits per line