Ouranosinc / xscen / 26841998442

90%

push

github

Rewrite attrs coercition (#743)

<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [x] This PR addresses an already opened issue (for bug fixes /
features)
    - This PR fixes Ouranosinc/data-requests#54
- [x] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [x] (If applicable) Tests have been added.
- [x] This PR does not seem to break the templates.
- [x] CHANGELOG.rst has been updated (with summary of main changes).
- [x] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?
Rewrite of `_coerce_attrs`. I tried to be smart here and not have to
list all the potential correct dtypes. Instead, I relied on numpy to
"cast" the attribute into an array and used the resulting dtype.

If "O" (object), then it's probably something funky, cast as string.
If not a scalar, format to a single string, comma-separated.

The last change was to fix a bug discovered while writing the test. At
least h5py can't write attributes that are arrays of strings. I made the
arbitrary decision not to try to support sequence attributes at all.

### Does this PR introduce a breaking change?
Sequence attributes are always formatted to a string.

Not sure how breaking this is.

### Other information:

4 of 4 new or added lines in 1 file covered. (100.0%)

4438 of 4927 relevant lines covered (90.08%)

9.74 hits per line