rero / rero-ils / 26760651405

91%

Build Type

push

github

Committed by PascalRepond

Commit Message

feat(patrons): add task for automatic deletion of inactive patrons

Add a monthly Celery task that deletes inactive patron profiles per
organisation based on configurable criteria: expiration date, last login
date, patron type exclusion list.

- Add patron_cleanup config to organisation schema and ES mapping
- Register task in CELERY_BEAT_SCHEDULE
- Add ptrn to operation log record type enum
- Fix circular import: move current_librarian to local import in
  operation_logs/extensions.py
- Skip operation log creation when the record has no pid (e.g. hard
  delete of a soft-deleted record whose data dict has been cleared)
- Use timezone-aware datetimes in the cleanup task to compare safely
  with user.current_login_at (UTC-aware from PostgreSQL)
- Update test_stats_librarian and test_stats_pricing mocks to target
  rero_ils.modules.patrons.api.current_librarian after the import move
- Refactor test_unpaid_subscription: replace setdefault (which left
  the limit at its fixture value of False) with direct assignment,
  wrap the test in try/finally to restore the module-scoped
  patron_type, fix the response check to assert res.status_code, and
  document a re-login workaround for the babel-triggered _load_user
- Add tests for task_delete_inactive_patrons covering each deletion
  criterion (expiration, inactivity, blocked, excluded type, active
  loans/transactions/ILL requests, never-logged-in user, dry-run,
  end-to-end)
- Add test for ill_requests in Patron.get_links_to_me
- Also adds Claude behavioural guidelines for implementation.

Closes US#2802

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>

Coverage Stats

49 of 51 new or added lines in 2 files covered. (96.08%)

9 existing lines in 1 file now uncovered.

24133 of 26423 relevant lines covered (91.33%)

0.91 hits per line