dcdpr / jp / 26806176212

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(llm, cli, config): Retry dropped connections + flush on abort (#714)

Distinguish a clean stream completion from a dropped connection across
all three providers: `Finished` is now emitted only from the real
protocol terminal event (`message_stop` for Anthropic, `done` for
Ollama, `ResponseCompleted/Incomplete/Failed` for OpenAI) rather than
being unconditionally chained after every stream.

The retry layer in `collect_with_retry` now treats a stream that ends
without `Event::Finished` as a transient failure, rebuilding and
replaying from where it left off. `StreamEnded` from `eventsource` and
`reqwest::Error` with no HTTP status (transport-level failures such as a
dropped connection mid-body) are likewise classified as retryable.

The idle timeout in `with_idle_timeout` is updated to measure elapsed
time against the wall clock (`SystemTime`) rather than the monotonic
timer. The monotonic clock pauses during system sleep on macOS and
Linux, so a stream interrupted by closing the laptop lid would hang for
a further full idle window after wake before retrying. The new
implementation polls on a short cadence (`IDLE_POLL_INTERVAL = 3s`) and
fires within one tick of the lid reopening. The default
`stream_idle_timeout_secs` is reduced from 60 to 30 to recover faster
from dead streams under normal network conditions.

Partial content is now flushed to `ConversationStream` unconditionally
in `handle_stream_error` — before the retry/abort decision — so that
streamed output the user already saw is never discarded on a fatal
error. `run_turn_loop` additionally calls `conv.flush()` before
propagating a fatal error, so that partial work is persisted to disk.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

52 of 73 new or added lines in 8 files covered. (71.23%)

4 existing lines in 4 files now uncovered.

33317 of 50138 relevant lines covered (66.45%)

239.02 hits per line