dcdpr / jp / 26805864183

67%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cli, tool): Guard temp line behind TTY and fix multi-tool collision (#713)

The streaming "Calling tool…" temp line uses cursor-relative control
sequences (`\r`, `\x1b[K`) that only make sense on a real TTY. When jp
was piped, those raw bytes leaked into the output. All temp line writes
are now gated behind `is_tty`.

A second bug caused a visible collision when two tool calls were
in-flight and the first completed: `complete` was immediately redrawing
the temp line for the still-pending tool, which landed on the same line
as the permanent header the caller was about to print, producing output
like `…fs_read_fileCalling tool…`. The fix changes `complete` to only
clear the line; the next timer tick is responsible for redrawing it.

Two smaller state-tracking issues were fixed alongside this:

- `tick` now sets `line_active = true` after writing, so a subsequent
`complete` call knows to clear the line even if `register` ran before
the first tick.

- `clear_temp_line` was guarded by `pending.is_empty()` instead of
`line_active`, so it would skip the clear when tools were pending but
the line had already been erased.

- `reset` was zeroing `line_active` before calling `cancel_all`, which
caused `cancel_all` to skip clearing a line that was still visible on
screen. The pre-clear is removed; `cancel_all` now owns that
responsibility.

A `visible_lines` test helper is added to emulate terminal cursor
movement (`\r`, `\x1b[K`) so tests can assert against what the user
actually sees rather than raw byte sequences.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Coverage Stats

10 of 11 new or added lines in 1 file covered. (90.91%)

9 existing lines in 3 files now uncovered.

33279 of 50102 relevant lines covered (66.42%)

231.42 hits per line