philihp / openskill.js / 26803187724

100%

push

github

fix: treat zero-indexed equal ranks as draws (#999)

The rankings helper used `rank[i] || i`, which falls back to the team
index whenever a rank is 0 (falsy). This turned a zero-indexed draw such
as rank: [0, 0] into a ranked outcome [0, 1], producing a win/loss
instead of a tie. Using nullish coalescing (`rank[i] ?? i`) only falls
back to the index for genuinely missing ranks, so equal ranks (and equal
scores, which map to rank 0) are correctly treated as draws.

Fixes #262

https://claude.ai/code/session_01WY8h6aYpiYfRobypqjTHgB

Co-authored-by: Claude <noreply@anthropic.com>

169 of 169 branches covered (100.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

647 of 647 relevant lines covered (100.0%)

66.78 hits per line