lsm / neokai / 26801534950

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(codex-auth): stale token refresh, re-add after removal, logout/login cycle (#2052)

* fix(codex-auth): stale token refresh, re-add after removal, logout/login cycle

Three related fixes for the OpenAI Codex provider auth flow:

1. **Stale OAuth token**: When token refresh fails (invalid/revoked refresh
token), clear stale credentials via logout() so the user is prompted to
re-authenticate instead of getting repeated 401s.

2. **Cannot re-add provider after removal**: Built-in providers were
unregistered on delete but never re-registered on re-add. Now
initializeProviders() is called in auth.login and syncProviderToRegistry
to restore missing core providers to the registry.

3. **Logout button broken flow**: ProviderCredentialManager.removeCredentials
was updating auth_type to 'none', causing the UI to show "No authentication
required" instead of a Login button after logout. Removed the auth_type
mutation so the provider's required auth type is preserved.

Tests added/updated for all three fixes.

* fix(codex-auth): address review feedback on refresh, re-register, logout

1. Distinguish transient vs definitive token refresh failures:
   - refreshCodexToken now returns CodexRefreshResult with a `definitive` flag
   - 4xx errors (except 408/429) = definitive (invalid/revoked token)
   - 5xx, 429, network errors = transient (preserve credentials)
   - Only clear credentials on definitive failures

2. Re-register only the provider being restored:
   - Added registerBuiltInProvider(factory) that registers a single provider by ID
   - Used in auth.login and syncProviderToRegistry instead of initializeProviders()
   - Prevents deleted providers from being resurrected when unrelated built-ins are added

3. Remove persisted stale credential rows:
   - auth.refresh now calls credentialManager.removeCredentials() on definitive failure
   - auth.logout now always calls removeCredentials() after provider.logout()
   - syncProviderToRegistry skips applying store... (continued)

Coverage Stats

9896 of 14446 branches covered (68.5%)

Branch coverage included in aggregate %.

55 of 106 new or added lines in 4 files covered. (51.89%)

208 existing lines in 1 file now uncovered.

82884 of 97719 relevant lines covered (84.82%)

296.96 hits per line