ben-manes / caffeine / #5494

100%

master: 100%

push

github

Fix JCache zero-creation-expiry, Guava null-query, and simulator bugs

JCache: two write paths ignored a zero creation expiry. Per
ExpiryPolicy.getExpiryForCreation (JSR-107 1.1.1), a Duration.ZERO entry 'will
not be added to the Cache', but the EntryProcessor create/load path
(CacheProxy.postProcess) recorded a put and published a CREATED event, and
putIfAbsent (putIfAbsentNoAwait set its absent flag before the zero-expiry
guard) recorded a put and returned true -- both for an entry that is never
added, unlike the guarded put()/getAndPut(). Mirror the put guard in both: skip
the put stat and CREATED event, publish EXPIRED, store nothing; putIfAbsent now
returns false. A new write-path parity test
(JCacheCreationExpiryTest.writeOp_absent_zeroCreationExpiry over
put/putAll/putIfAbsent/getAndPut/invoke) asserts every path agrees. Verified
against the RI, Ehcache 2/3, Infinispan, Hazelcast, Coherence, and cache2k: the
entry is added in none; no put is counted in 6/7 (incl. the RI); putIfAbsent
returns false in the RI.

Guava: keep the facade a drop-in for Guava. Match its asMap null-query
tolerance: get/containsKey/containsValue/remove/remove(k,v)/replace(k,null,v)
and keySet()/values().contains/containsAll now tolerate null (return
null/false) instead of throwing, and getAllPresent drops a null element. The
testlib suite is raised to ALLOWS_ANY_NULL_QUERIES and is now also run against
real Guava (GuavaMapTests) to guard against divergence; both pass. A
method-by-method cross-check against Guava 33.6.0's LocalCache source also
fixed two behavioral divergences the testlib does not assert:
invalidateAll(Iterable) threw NPE on a null element after a partial removal (now
filters nulls like getAllPresent), and entrySet().addAll(emptyCollection) threw
UnsupportedOperationException where Guava returns false.

Simulator: GLCacheTraceReader read the little-endian libCacheSim oracleGeneral
record as big-endian (mirror the OracleGeneralTraceReader sibling); Adam/Na... (continued)

4034 of 4042 branches covered (99.8%)

18 of 18 new or added lines in 2 files covered. (100.0%)

8218 of 8218 relevant lines covered (100.0%)

1.0 hits per line