ben-manes / caffeine / #5487

100%

push

github

Test strong-value conditional remove/replace match by equality

Conditional remove(k, v) and replace(k, old, new) match the expected value by
Objects.equals for strong values but by identity (==) for weak/soft. The
*_byIdentity tests cover the weak/soft side, but no test covered the strong side
with a distinct-but-equal instance: Int interning makes the populated values
identity-shared, so every existing conditional test passes the same instance and
the == fast path short-circuits before equals. A regression consolidating the
matcher to == would break the ConcurrentMap contract for strong values yet pass
the whole suite.

Add a strong/strong test that probes with new Int(value) (distinct but equal),
asserting the match succeeds — exercising the equals path the interned values hid.

Found by an audit of the test suite's own coverage.

4010 of 4018 branches covered (99.8%)

8205 of 8205 relevant lines covered (100.0%)

1.0 hits per line