ruby-grape / grape / 26784519840

97%

master: 97%

Pull #2757

github

Skip response-cookie flush when no cookie was touched

`Grape::Endpoint#build_response_cookies` runs on every request and
delegates through `cookies` -> `request.cookies`, materializing the
`Grape::Cookies` jar (and its `-> { rack_cookies }` Proc) even when the
handler never read or wrote a cookie. The jar's `response_cookies` then
immediately no-ops because nothing was set.

Add `Grape::Request#cookies?`, true only once the jar has been
materialized, and gate `build_response_cookies` on it. A Set-Cookie is
only ever emitted after a `cookies[...] =` write, which always
materializes the jar first, so behaviour is unchanged; the cookie-free
request path now allocates zero cookie objects (~10 fewer allocations
per request, counting the transitive Forwardable/internal churn).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1116 of 1207 branches covered (92.46%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 3 files covered. (100.0%)

3545 of 3606 relevant lines covered (98.31%)

23198.37 hits per line